Remove useless rightJoin (#851)

This commit is contained in:
MartinOscar 2024-12-31 14:05:14 +01:00 committed by GitHub
parent 9a859cdec3
commit b5733715a6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -306,10 +306,9 @@ class Server extends Model
public function viewableServerVariables(): HasMany
{
return $this->hasMany(ServerVariable::class)->rightJoin('egg_variables', function (JoinClause $join) {
$join->on('egg_variables.id', 'server_variables.variable_id')
->where('egg_variables.user_viewable', true);
});
return $this->serverVariables()
->join('egg_variables', 'egg_variables.id', '=', 'server_variables.variable_id')
->where('egg_variables.user_viewable', true);
}
/**