From b5733715a64a0e34191d44ba61ce7b78cbf3e31b Mon Sep 17 00:00:00 2001
From: MartinOscar <40749467+RMartinOscar@users.noreply.github.com>
Date: Tue, 31 Dec 2024 14:05:14 +0100
Subject: [PATCH] Remove useless rightJoin (#851)

---
 app/Models/Server.php | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/Models/Server.php b/app/Models/Server.php
index 786da3743..548090d42 100644
--- a/app/Models/Server.php
+++ b/app/Models/Server.php
@@ -306,10 +306,9 @@ class Server extends Model
 
     public function viewableServerVariables(): HasMany
     {
-        return $this->hasMany(ServerVariable::class)->rightJoin('egg_variables', function (JoinClause $join) {
-            $join->on('egg_variables.id', 'server_variables.variable_id')
-                ->where('egg_variables.user_viewable', true);
-        });
+        return $this->serverVariables()
+            ->join('egg_variables', 'egg_variables.id', '=', 'server_variables.variable_id')
+            ->where('egg_variables.user_viewable', true);
     }
 
     /**