expense reports #39

Merged
mateo.ziegler merged 6 commits from note-de-frais into dev 2026-07-30 15:24:22 +02:00
No description provided.
@ -0,0 +20,4 @@
) {
@Transactional
fun createExpenseReport(expenseReportRequest: NewExpenseReportRequest, authorIdentity: SecurityIdentity): ExpenseReport {
Author
Owner

peut etre rename le param genre expenseReportRequest en request, ca fera plus court et plus lisible

peut etre rename le param genre `expenseReportRequest` en `request`, ca fera plus court et plus lisible
mateo.ziegler marked this conversation as resolved
@ -0,0 +27,4 @@
/**************************** ERROR CHECKING ****************************/
var isAllowed = false
println(authorIdentity.roles.toString())
Author
Owner

rm le println

rm le `println`
mateo.ziegler marked this conversation as resolved
@ -0,0 +68,4 @@
if (expenseReport.status != ExpenseReportStatus.PENDING)
throw Exception("Can't reject this exepense report, as it is not pending")
expenseReport.status = ExpenseReportStatus.APPROVED
Author
Owner

askApproval et approve echanges, et il manque approve

askApproval et approve echanges, et il manque approve
mateo.ziegler marked this conversation as resolved
@ -0,0 +78,4 @@
if (expenseReport.status != ExpenseReportStatus.APPROVED)
throw Exception("Can't reject this expense report, as it is not pending")
//TODO: A voir avec Arthur
Author
Owner

il manque de passer le status en draft, la aucun changement de status est fait

il manque de passer le status en draft, la aucun changement de status est fait
mateo.ziegler marked this conversation as resolved
@ -0,0 +86,4 @@
val expenseReport = expenseReportRepository.getExpenseReport(expenseReportId)
if (expenseReport.status != ExpenseReportStatus.PENDING)
throw Exception("Can't reject this expense report, as it is not pending")
Author
Owner

pareil, il manque de passer le status en rejected, la aucun changement de status est fait

pareil, il manque de passer le status en rejected, la aucun changement de status est fait
mateo.ziegler marked this conversation as resolved
@ -0,0 +41,4 @@
expenseReportRequest : NewExpenseReportRequest
): ExpenseReportResponse {
// TODO : Security checks
val authorIdentity = securityIdentity
Author
Owner

variable inutile

variable inutile
mateo.ziegler marked this conversation as resolved
@ -0,0 +15,4 @@
val status: ExpenseReportStatus?,
val createdAt: LocalDateTime,
val paidAt:LocalDateTime?,
val subAccountId: Long
Author
Owner

manque le bankAccountId mais sinon good

manque le bankAccountId mais sinon good
mateo.ziegler marked this conversation as resolved
mateo.ziegler deleted branch note-de-frais 2026-07-30 15:24:22 +02:00
mateo.ziegler referenced this pull request from a commit 2026-07-30 15:24:24 +02:00
Sign in to join this conversation.
No description provided.