expense reports #39
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
banquise/laundering!39
Loading…
Reference in a new issue
No description provided.
Delete branch "note-de-frais"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +20,4 @@) {@Transactionalfun createExpenseReport(expenseReportRequest: NewExpenseReportRequest, authorIdentity: SecurityIdentity): ExpenseReport {peut etre rename le param genre
expenseReportRequestenrequest, ca fera plus court et plus lisible@ -0,0 +27,4 @@/**************************** ERROR CHECKING ****************************/var isAllowed = falseprintln(authorIdentity.roles.toString())rm le
println@ -0,0 +68,4 @@if (expenseReport.status != ExpenseReportStatus.PENDING)throw Exception("Can't reject this exepense report, as it is not pending")expenseReport.status = ExpenseReportStatus.APPROVEDaskApproval et approve echanges, et il manque approve
@ -0,0 +78,4 @@if (expenseReport.status != ExpenseReportStatus.APPROVED)throw Exception("Can't reject this expense report, as it is not pending")//TODO: A voir avec Arthuril manque de passer le status en draft, la aucun changement de status est fait
@ -0,0 +86,4 @@val expenseReport = expenseReportRepository.getExpenseReport(expenseReportId)if (expenseReport.status != ExpenseReportStatus.PENDING)throw Exception("Can't reject this expense report, as it is not pending")pareil, il manque de passer le status en rejected, la aucun changement de status est fait
@ -0,0 +41,4 @@expenseReportRequest : NewExpenseReportRequest): ExpenseReportResponse {// TODO : Security checksval authorIdentity = securityIdentityvariable inutile
@ -0,0 +15,4 @@val status: ExpenseReportStatus?,val createdAt: LocalDateTime,val paidAt:LocalDateTime?,val subAccountId: Longmanque le bankAccountId mais sinon good
15e6a1ffddto2b9dc17480