From f2eca17480bf95b56851c2acc115a18c04f25aa0 Mon Sep 17 00:00:00 2001 From: Lance Pioch Date: Tue, 2 Jul 2024 11:50:46 -0400 Subject: [PATCH] Use constants --- app/Filament/Resources/NodeResource/Pages/CreateNode.php | 5 +++-- app/Filament/Resources/NodeResource/Pages/EditNode.php | 5 +++-- app/Filament/Resources/ServerResource/Pages/CreateServer.php | 2 +- app/Filament/Resources/ServerResource/Pages/EditServer.php | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/app/Filament/Resources/NodeResource/Pages/CreateNode.php b/app/Filament/Resources/NodeResource/Pages/CreateNode.php index 0e5075e75..c9eb90888 100644 --- a/app/Filament/Resources/NodeResource/Pages/CreateNode.php +++ b/app/Filament/Resources/NodeResource/Pages/CreateNode.php @@ -3,6 +3,7 @@ namespace App\Filament\Resources\NodeResource\Pages; use App\Filament\Resources\NodeResource; +use App\Models\Objects\Endpoint; use Filament\Forms\Components\Actions\Action; use Filament\Forms; use Filament\Forms\Components\Grid; @@ -139,7 +140,7 @@ class CreateNode extends CreateRecord ->label(trans('strings.port')) ->helperText('If you are running the daemon behind Cloudflare you should set the daemon port to 8443 to allow websocket proxying over SSL.') ->minValue(1) - ->maxValue(65535) + ->maxValue(Endpoint::PORT_CEIL) ->default(8080) ->required() ->integer(), @@ -249,7 +250,7 @@ class CreateNode extends CreateRecord ->columnSpan(1) ->label('SFTP Port') ->minValue(1) - ->maxValue(65535) + ->maxValue(Endpoint::PORT_CEIL) ->default(2022) ->required() ->integer(), diff --git a/app/Filament/Resources/NodeResource/Pages/EditNode.php b/app/Filament/Resources/NodeResource/Pages/EditNode.php index 94ea3a8a4..26e61771a 100644 --- a/app/Filament/Resources/NodeResource/Pages/EditNode.php +++ b/app/Filament/Resources/NodeResource/Pages/EditNode.php @@ -6,6 +6,7 @@ use App\Filament\Resources\NodeResource; use App\Filament\Resources\NodeResource\Widgets\NodeMemoryChart; use App\Filament\Resources\NodeResource\Widgets\NodeStorageChart; use App\Models\Node; +use App\Models\Objects\Endpoint; use App\Services\Nodes\NodeUpdateService; use Filament\Actions; use Filament\Forms; @@ -142,7 +143,7 @@ class EditNode extends EditRecord ->label(trans('strings.port')) ->helperText('If you are running the daemon behind Cloudflare you should set the daemon port to 8443 to allow websocket proxying over SSL.') ->minValue(1) - ->maxValue(65535) + ->maxValue(Endpoint::PORT_CEIL) ->default(8080) ->required() ->integer(), @@ -227,7 +228,7 @@ class EditNode extends EditRecord ->columnSpan(['default' => 1, 'sm' => 1, 'md' => 1, 'lg' => 3]) ->label('SFTP Port') ->minValue(1) - ->maxValue(65535) + ->maxValue(Endpoint::PORT_CEIL) ->default(2022) ->required() ->integer(), diff --git a/app/Filament/Resources/ServerResource/Pages/CreateServer.php b/app/Filament/Resources/ServerResource/Pages/CreateServer.php index 4d5db0155..968e84f66 100644 --- a/app/Filament/Resources/ServerResource/Pages/CreateServer.php +++ b/app/Filament/Resources/ServerResource/Pages/CreateServer.php @@ -748,7 +748,7 @@ class CreateServer extends CreateRecord $ports = $uniquePorts; } - $ports = $ports->filter(fn ($port) => $port > 1024 && $port < 65535)->values(); + $ports = $ports->filter(fn ($port) => $port > Endpoint::PORT_FLOOR && $port < Endpoint::PORT_CEIL)->values(); $set('ports', $ports->all()); $this->ports = $ports->all(); diff --git a/app/Filament/Resources/ServerResource/Pages/EditServer.php b/app/Filament/Resources/ServerResource/Pages/EditServer.php index c4c80a536..56c33a295 100644 --- a/app/Filament/Resources/ServerResource/Pages/EditServer.php +++ b/app/Filament/Resources/ServerResource/Pages/EditServer.php @@ -905,7 +905,7 @@ class EditServer extends EditRecord $ports = $uniquePorts; } - $ports = $ports->filter(fn ($port) => $port > 1024 && $port < 65535)->values(); + $ports = $ports->filter(fn ($port) => $port > Endpoint::PORT_FLOOR && $port < Endpoint::PORT_CEIL)->values(); $set('ports', $ports->all()); $this->ports = $ports->all();