From e014581ebbb60c9a50a17b2276be9d7175683f5f Mon Sep 17 00:00:00 2001
From: Boy132 <mail@boy132.de>
Date: Mon, 10 Nov 2025 09:56:43 +0100
Subject: [PATCH] update `p:plugin:make` command

---
 .../Commands/Plugin/MakePluginCommand.php     | 39 ++++++++++++-------
 1 file changed, 25 insertions(+), 14 deletions(-)

diff --git a/app/Console/Commands/Plugin/MakePluginCommand.php b/app/Console/Commands/Plugin/MakePluginCommand.php
index e2c9eae13..7d51d924e 100644
--- a/app/Console/Commands/Plugin/MakePluginCommand.php
+++ b/app/Console/Commands/Plugin/MakePluginCommand.php
@@ -18,7 +18,7 @@ class MakePluginCommand extends Command
                             {--url=}
                             {--updateUrl=}
                             {--panels=}
-                            {--composerPackages=}';
+                            {--panelVersion=}';
 
     protected $description = 'Create a new plugin';
 
@@ -55,7 +55,7 @@ class MakePluginCommand extends Command
 
         $this->info('Creating Plugin "' . $name . '" (' . $id . ') by ' . $author);
 
-        $description = $this->option('description') ?? $this->ask('Description');
+        $description = $this->option('description') ?? $this->ask('Description (can be empty)');
 
         $category = $this->option('category') ?? $this->choice('Category', collect(PluginCategory::cases())->mapWithKeys(fn (PluginCategory $category) => [$category->value => $category->getLabel()])->toArray(), PluginCategory::Plugin->value);
 
@@ -65,25 +65,32 @@ class MakePluginCommand extends Command
             return;
         }
 
-        $url = $this->option('url') ?? $this->ask('URL');
-        $updateUrl = $this->option('updateUrl') ?? $this->ask('Update URL');
-        $panels = $this->option('panels') ?? $this->choice('Panels', [
+        $url = $this->option('url') ?? $this->ask('URL (can be empty)');
+        $updateUrl = $this->option('updateUrl') ?? $this->ask('Update URL (can be empty)');
+
+        $panels = $this->option('panels') ?? $this->choice('Panels (leave empty for "all panels", otherwise comma separated list)', [
             'admin' => 'Admin Area',
             'server' => 'Client Area',
             'app' => 'Server List',
-        ], 'admin,server', multiple: true);
-        $composerPackages = $this->option('composerPackages') ?? $this->ask('Composer Packages');
+        ], multiple: true);
+
+        $panelVersion = $this->option('panelVersion');
+        if (!$panelVersion) {
+            $panelVersion = $this->ask('Required panel version (leave empty for no constraint)', config('app.version') === 'canary' ? null : config('app.version'));
+
+            if ($panelVersion && $this->confirm("Should the version constraint be minimal instead of strict? ($panelVersion or higher instead of only $panelVersion)")) {
+                $panelVersion = "^$panelVersion";
+            }
+        }
+
+        $composerPackages = null;
+        // TODO: ask for composer packages?
 
         // Create base directory
         $this->filesystem->makeDirectory(plugin_path($id));
 
         // Write plugin.json
         $this->filesystem->put(plugin_path($id, 'plugin.json'), json_encode([
-            'meta' => [
-                'status' => PluginStatus::Enabled,
-                'status_message' => null,
-                'load_order' => 0,
-            ],
             'id' => $id,
             'name' => $name,
             'author' => $author,
@@ -95,8 +102,12 @@ class MakePluginCommand extends Command
             'namespace' => $namespace,
             'class' => $class,
             'panels' => is_string($panels) ? explode(',', $panels) : $panels,
-            'panel_version' => config('app.version') === 'canary' ? null : config('app.version'),
-            'composer_packages' => is_string($composerPackages) ? explode(',', $composerPackages) : $composerPackages,
+            'panel_version' => $panelVersion,
+            'composer_packages' => $composerPackages,
+            'meta' => [
+                'status' => PluginStatus::Enabled,
+                'status_message' => null,
+            ],
         ], JSON_THROW_ON_ERROR | JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES));
 
         // Create src directory and create main class