Fix Save Notification icon & Cleanup (#1959)

2025-12-08 18:30:15 +01:00 · 2025-12-03 01:23:09 +00:00 · 2025-12-03 01:23:09 +00:00 · bda2f9a699
commit bda2f9a699
parent 04375439d7
27 changed files with 72 additions and 54 deletions
--- a/app/Filament/Admin/Resources/ApiKeys/ApiKeyResource.php
+++ b/app/Filament/Admin/Resources/ApiKeys/ApiKeyResource.php
@ -97,8 +97,7 @@ class ApiKeyResource extends Resource
            ])
            ->recordActions([
                DeleteAction::make()
-                    ->iconButton()->iconSize(IconSize::ExtraLarge)
-                    ->icon('tabler-trash'),
+                    ->iconButton()->iconSize(IconSize::ExtraLarge),
            ])
            ->emptyStateIcon('tabler-key')
            ->emptyStateDescription('')
--- a/app/Filament/Admin/Resources/DatabaseHosts/Pages/EditDatabaseHost.php
+++ b/app/Filament/Admin/Resources/DatabaseHosts/Pages/EditDatabaseHost.php
@ -38,8 +38,7 @@ class EditDatabaseHost extends EditRecord
            DeleteAction::make()
                ->label(fn (DatabaseHost $databaseHost) => $databaseHost->databases()->count() > 0 ? trans('admin/databasehost.delete_help') : trans('filament-actions::delete.single.modal.actions.delete.label'))
                ->disabled(fn (DatabaseHost $databaseHost) => $databaseHost->databases()->count() > 0)
-                ->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-trash'),
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
            $this->getSaveFormAction()->formId('form')
                ->iconButton()->iconSize(IconSize::ExtraLarge)
                ->icon('tabler-device-floppy'),
--- a/app/Filament/Admin/Resources/DatabaseHosts/Pages/ViewDatabaseHost.php
+++ b/app/Filament/Admin/Resources/DatabaseHosts/Pages/ViewDatabaseHost.php
@ -9,6 +9,7 @@ use Filament\Actions\Action;
 use Filament\Actions\ActionGroup;
 use Filament\Actions\EditAction;
 use Filament\Resources\Pages\ViewRecord;
+use Filament\Support\Enums\IconSize;

 class ViewDatabaseHost extends ViewRecord
 {
@ -21,7 +22,8 @@ class ViewDatabaseHost extends ViewRecord
    protected function getDefaultHeaderActions(): array
    {
        return [
-            EditAction::make(),
+            EditAction::make()
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
        ];
    }
 }
--- a/app/Filament/Admin/Resources/DatabaseHosts/RelationManagers/DatabasesRelationManager.php
+++ b/app/Filament/Admin/Resources/DatabaseHosts/RelationManagers/DatabasesRelationManager.php
@ -71,8 +71,7 @@ class DatabasesRelationManager extends RelationManager
                ViewAction::make()
                    ->color('primary'),
                DeleteAction::make()
-                    ->iconButton()->iconSize(IconSize::ExtraLarge)
-                    ->icon('tabler-trash'),
+                    ->iconButton()->iconSize(IconSize::ExtraLarge),
            ]);
    }
 }
--- a/app/Filament/Admin/Resources/Eggs/Pages/EditEgg.php
+++ b/app/Filament/Admin/Resources/Eggs/Pages/EditEgg.php
@ -452,8 +452,7 @@ class EditEgg extends EditRecord
            DeleteAction::make()
                ->disabled(fn (Egg $egg): bool => $egg->servers()->count() > 0)
                ->label(fn (Egg $egg): string => $egg->servers()->count() <= 0 ? trans('filament-actions::delete.single.label') : trans('admin/egg.in_use'))
-                ->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-trash'),
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
            ExportEggAction::make(),
            ImportEggAction::make()
                ->multiple(false),
--- a/app/Filament/Admin/Resources/Eggs/Pages/ListEggs.php
+++ b/app/Filament/Admin/Resources/Eggs/Pages/ListEggs.php
@ -64,17 +64,18 @@ class ListEggs extends ListRecords
            ->recordActions([
                EditAction::make()
                    ->iconButton()
-                    ->tooltip(trans('filament-actions::edit.single.label')),
+                    ->tooltip(trans('filament-actions::edit.single.label'))
+                    ->iconSize(IconSize::Large),
                ExportEggAction::make()
-                    ->iconButton()
                    ->tooltip(trans('filament-actions::export.modal.actions.export.label'))
                    ->iconSize(IconSize::Large),
                UpdateEggAction::make()
-                    ->iconButton()
-                    ->tooltip(trans_choice('admin/egg.update', 1)),
+                    ->tooltip(trans_choice('admin/egg.update', 1))
+                    ->iconSize(IconSize::Large),
                ReplicateAction::make()
                    ->iconButton()
                    ->tooltip(trans('filament-actions::replicate.single.label'))
+                    ->iconSize(IconSize::Large)
                    ->modal(false)
                    ->excludeAttributes(['author', 'uuid', 'update_url', 'servers_count', 'created_at', 'updated_at'])
                    ->beforeReplicaSaved(function (Egg $replica) {
--- a/app/Filament/Admin/Resources/Mounts/Pages/EditMount.php
+++ b/app/Filament/Admin/Resources/Mounts/Pages/EditMount.php
@ -23,8 +23,7 @@ class EditMount extends EditRecord
    {
        return [
            DeleteAction::make()
-                ->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-trash'),
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
            $this->getSaveFormAction()->formId('form')
                ->iconButton()->iconSize(IconSize::ExtraLarge)
                ->icon('tabler-device-floppy'),
--- a/app/Filament/Admin/Resources/Mounts/Pages/ViewMount.php
+++ b/app/Filament/Admin/Resources/Mounts/Pages/ViewMount.php
@ -23,7 +23,6 @@ class ViewMount extends ViewRecord
    {
        return [
            EditAction::make()
-                ->icon('tabler-edit')
                ->iconSize(IconSize::ExtraLarge)
                ->iconButton(),
        ];
--- a/app/Filament/Admin/Resources/Nodes/Pages/EditNode.php
+++ b/app/Filament/Admin/Resources/Nodes/Pages/EditNode.php
@ -811,8 +811,7 @@ class EditNode extends EditRecord
            DeleteAction::make()
                ->disabled(fn (Node $node) => $node->servers()->count() > 0)
                ->label(fn (Node $node) => $node->servers()->count() > 0 ? trans('admin/node.node_has_servers') : trans('filament-actions::delete.single.label'))
-                ->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-trash'),
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
            $this->getSaveFormAction()->formId('form')
                ->iconButton()->iconSize(IconSize::ExtraLarge)
                ->icon('tabler-device-floppy'),
--- a/app/Filament/Admin/Resources/Roles/Pages/CreateRole.php
+++ b/app/Filament/Admin/Resources/Roles/Pages/CreateRole.php
@ -9,6 +9,7 @@ use App\Traits\Filament\CanCustomizeHeaderWidgets;
 use Filament\Actions\Action;
 use Filament\Actions\ActionGroup;
 use Filament\Resources\Pages\CreateRecord;
+use Filament\Support\Enums\IconSize;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Collection;
 use Spatie\Permission\Models\Permission;
@ -31,7 +32,9 @@ class CreateRole extends CreateRecord
    protected function getDefaultHeaderActions(): array
    {
        return [
-            $this->getCreateFormAction()->formId('form'),
+            $this->getCreateFormAction()->formId('form')
+                ->iconButton()->iconSize(IconSize::ExtraLarge)
+                ->icon('tabler-plus'),
        ];
    }

--- a/app/Filament/Admin/Resources/Roles/Pages/EditRole.php
+++ b/app/Filament/Admin/Resources/Roles/Pages/EditRole.php
@ -60,7 +60,6 @@ class EditRole extends EditRecord
            DeleteAction::make()
                ->label(fn (Role $role) => $role->isRootAdmin() ? trans('admin/role.root_admin_delete') : ($role->users_count >= 1 ? trans('admin/role.in_use') : trans('filament-actions::delete.single.label')))
                ->disabled(fn (Role $role) => $role->isRootAdmin() || $role->users_count >= 1)
-                ->icon('tabler-trash')
                ->iconButton()->iconSize(IconSize::ExtraLarge),
            $this->getSaveFormAction()->formId('form')
                ->iconButton()->iconSize(IconSize::ExtraLarge)
--- a/app/Filament/Admin/Resources/Roles/Pages/ViewRole.php
+++ b/app/Filament/Admin/Resources/Roles/Pages/ViewRole.php
@ -9,6 +9,7 @@ use Filament\Actions\Action;
 use Filament\Actions\ActionGroup;
 use Filament\Actions\EditAction;
 use Filament\Resources\Pages\ViewRecord;
+use Filament\Support\Enums\IconSize;

 class ViewRole extends ViewRecord
 {
@ -21,7 +22,8 @@ class ViewRole extends ViewRecord
    protected function getDefaultHeaderActions(): array
    {
        return [
-            EditAction::make(),
+            EditAction::make()
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
        ];
    }
 }
--- a/app/Filament/Admin/Resources/Servers/RelationManagers/AllocationsRelationManager.php
+++ b/app/Filament/Admin/Resources/Servers/RelationManagers/AllocationsRelationManager.php
@ -8,7 +8,6 @@ use App\Models\Server;
 use App\Services\Allocations\AssignmentService;
 use Filament\Actions\Action;
 use Filament\Actions\AssociateAction;
-use Filament\Actions\BulkActionGroup;
 use Filament\Actions\CreateAction;
 use Filament\Actions\DissociateAction;
 use Filament\Actions\DissociateBulkAction;
@ -95,7 +94,6 @@ class AllocationsRelationManager extends RelationManager
                    }),
            ])
            ->toolbarActions([
-                BulkActionGroup::make([
                DissociateBulkAction::make()
                    ->after(function () {
                        Allocation::whereNull('server_id')->update([
@ -107,7 +105,6 @@ class AllocationsRelationManager extends RelationManager
                            $this->getOwnerRecord()->update(['allocation_id' => $this->getOwnerRecord()->allocations()->first()?->id]);
                        }
                    }),
-                ]),
                CreateAction::make()
                    ->label(trans('admin/server.create_allocation'))
                    ->icon('tabler-network')
--- a/app/Filament/Admin/Resources/Servers/RelationManagers/DatabasesRelationManager.php
+++ b/app/Filament/Admin/Resources/Servers/RelationManagers/DatabasesRelationManager.php
@ -84,7 +84,6 @@ class DatabasesRelationManager extends RelationManager
                    ->color('primary'),
                DeleteAction::make()
                    ->iconButton()->iconSize(IconSize::ExtraLarge)
-                    ->icon('tabler-trash')
                    ->successNotificationTitle(null)
                    ->using(function (Database $database, DatabaseManagementService $service) {
                        try {
--- a/app/Filament/Admin/Resources/Users/Pages/CreateUser.php
+++ b/app/Filament/Admin/Resources/Users/Pages/CreateUser.php
@ -10,6 +10,7 @@ use App\Traits\Filament\CanCustomizeHeaderWidgets;
 use Filament\Actions\Action;
 use Filament\Actions\ActionGroup;
 use Filament\Resources\Pages\CreateRecord;
+use Filament\Support\Enums\IconSize;
 use Illuminate\Database\Eloquent\Model;

 class CreateUser extends CreateRecord
@ -32,7 +33,9 @@ class CreateUser extends CreateRecord
    protected function getDefaultHeaderActions(): array
    {
        return [
-            $this->getCreateFormAction()->formId('form'),
+            $this->getCreateFormAction()->formId('form')
+                ->iconButton()->iconSize(IconSize::ExtraLarge)
+                ->icon('tabler-user-plus'),
        ];
    }

--- a/app/Filament/Admin/Resources/Users/Pages/EditUser.php
+++ b/app/Filament/Admin/Resources/Users/Pages/EditUser.php
@ -35,8 +35,7 @@ class EditUser extends EditRecord
            DeleteAction::make()
                ->label(fn (User $user) => user()?->id === $user->id ? trans('admin/user.self_delete') : ($user->servers()->count() > 0 ? trans('admin/user.has_servers') : trans('filament-actions::delete.single.modal.actions.delete.label')))
                ->disabled(fn (User $user) => user()?->id === $user->id || $user->servers()->count() > 0)
-                ->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-trash'),
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
            $this->getSaveFormAction()->formId('form')
                ->iconButton()->iconSize(IconSize::ExtraLarge)
                ->icon('tabler-device-floppy'),
--- a/app/Filament/Admin/Resources/Users/Pages/ViewUser.php
+++ b/app/Filament/Admin/Resources/Users/Pages/ViewUser.php
@ -9,6 +9,7 @@ use Filament\Actions\Action;
 use Filament\Actions\ActionGroup;
 use Filament\Actions\EditAction;
 use Filament\Resources\Pages\ViewRecord;
+use Filament\Support\Enums\IconSize;

 class ViewUser extends ViewRecord
 {
@ -21,7 +22,8 @@ class ViewUser extends ViewRecord
    protected function getDefaultHeaderActions(): array
    {
        return [
-            EditAction::make(),
+            EditAction::make()
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
        ];
    }
 }
--- a/app/Filament/Admin/Resources/Webhooks/Pages/CreateWebhookConfiguration.php
+++ b/app/Filament/Admin/Resources/Webhooks/Pages/CreateWebhookConfiguration.php
@ -9,6 +9,7 @@ use App\Traits\Filament\CanCustomizeHeaderWidgets;
 use Filament\Actions\Action;
 use Filament\Actions\ActionGroup;
 use Filament\Resources\Pages\CreateRecord;
+use Filament\Support\Enums\IconSize;

 class CreateWebhookConfiguration extends CreateRecord
 {
@ -23,8 +24,10 @@ class CreateWebhookConfiguration extends CreateRecord
    protected function getDefaultHeaderActions(): array
    {
        return [
-            $this->getCancelFormAction()->formId('form'),
-            $this->getCreateFormAction()->formId('form'),
+            $this->getCancelFormAction()->formId('form')
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
+            $this->getCreateFormAction()->formId('form')
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
        ];
    }

--- a/app/Filament/Admin/Resources/Webhooks/Pages/EditWebhookConfiguration.php
+++ b/app/Filament/Admin/Resources/Webhooks/Pages/EditWebhookConfiguration.php
@ -25,8 +25,7 @@ class EditWebhookConfiguration extends EditRecord
    {
        return [
            DeleteAction::make()
-                ->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-trash'),
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
            Action::make('test_now')
                ->label(trans('admin/webhook.test_now'))
                ->color('primary')
--- a/app/Filament/Admin/Resources/Webhooks/Pages/ViewWebhookConfiguration.php
+++ b/app/Filament/Admin/Resources/Webhooks/Pages/ViewWebhookConfiguration.php
@ -9,6 +9,7 @@ use Filament\Actions\Action;
 use Filament\Actions\ActionGroup;
 use Filament\Actions\EditAction;
 use Filament\Resources\Pages\ViewRecord;
+use Filament\Support\Enums\IconSize;

 class ViewWebhookConfiguration extends ViewRecord
 {
@ -21,7 +22,8 @@ class ViewWebhookConfiguration extends ViewRecord
    protected function getDefaultHeaderActions(): array
    {
        return [
-            EditAction::make(),
+            EditAction::make()
+                ->iconButton()->iconSize(IconSize::ExtraLarge),
        ];
    }
 }
--- a/app/Filament/Components/Actions/ExportEggAction.php
+++ b/app/Filament/Components/Actions/ExportEggAction.php
@ -7,6 +7,7 @@ use App\Models\Egg;
 use Filament\Actions\Action;
 use Filament\Infolists\Components\TextEntry;
 use Filament\Support\Enums\Alignment;
+use Filament\Support\Enums\IconSize;

 class ExportEggAction extends Action
 {
@ -27,6 +28,8 @@ class ExportEggAction extends Action

        $this->tableIcon('tabler-download');

+        $this->iconSize(IconSize::ExtraLarge);
+
        $this->authorize(fn () => user()?->can('export egg'));

        $this->modalHeading(fn (Egg $egg) => trans('filament-actions::export.modal.actions.export.label') . '  ' . $egg->name);
--- a/app/Filament/Components/Actions/ExportScheduleAction.php
+++ b/app/Filament/Components/Actions/ExportScheduleAction.php
@ -8,6 +8,7 @@ use App\Models\Server;
 use App\Services\Schedules\Sharing\ScheduleExporterService;
 use Filament\Actions\Action;
 use Filament\Facades\Filament;
+use Filament\Support\Enums\IconSize;

 class ExportScheduleAction extends Action
 {
@ -20,6 +21,16 @@ class ExportScheduleAction extends Action
    {
        parent::setUp();

+        $this->hiddenLabel();
+
+        $this->iconButton();
+
+        $this->iconSize(IconSize::ExtraLarge);
+
+        $this->icon('tabler-download');
+
+        $this->tooltip(trans('server/schedule.export'));
+
        /** @var Server $server */
        $server = Filament::getTenant();

--- a/app/Filament/Components/Actions/UpdateEggAction.php
+++ b/app/Filament/Components/Actions/UpdateEggAction.php
@ -7,6 +7,7 @@ use App\Services\Eggs\Sharing\EggImporterService;
 use Exception;
 use Filament\Actions\Action;
 use Filament\Notifications\Notification;
+use Filament\Support\Enums\IconSize;

 class UpdateEggAction extends Action
 {
@ -21,8 +22,12 @@ class UpdateEggAction extends Action

        $this->label(trans_choice('admin/egg.update', 1));

+        $this->iconButton();
+
        $this->icon('tabler-cloud-download');

+        $this->iconSize(IconSize::ExtraLarge);
+
        $this->color('success');

        $this->requiresConfirmation();
--- a/app/Filament/Server/Resources/Allocations/AllocationResource.php
+++ b/app/Filament/Server/Resources/Allocations/AllocationResource.php
@ -84,7 +84,6 @@ class AllocationResource extends Resource
                    ->visible(fn (Allocation $allocation) => !$allocation->is_locked || user()?->can('update', $allocation->node))
                    ->authorize(fn () => user()?->can(Permission::ACTION_ALLOCATION_DELETE, $server))
                    ->label(trans('server/network.delete'))
-                    ->icon('tabler-trash')
                    ->action(function (Allocation $allocation) {
                        Allocation::where('id', $allocation->id)->update([
                            'notes' => null,
--- a/app/Filament/Server/Resources/Files/Pages/ListFiles.php
+++ b/app/Filament/Server/Resources/Files/Pages/ListFiles.php
@ -137,7 +137,6 @@ class ListFiles extends ListRecords
                    ->url(fn (File $file) => self::getUrl(['path' => encode_path(join_paths($this->path, $file->name))])),
                EditAction::make('edit')
                    ->authorize(fn () => user()?->can(Permission::ACTION_FILE_READ_CONTENT, $server))
-                    ->icon('tabler-edit')
                    ->visible(fn (File $file) => $file->canEdit())
                    ->url(fn (File $file) => EditFiles::getUrl(['path' => encode_path(join_paths($this->path, $file->name))])),
                ActionGroup::make([
@ -359,7 +358,7 @@ class ListFiles extends ListRecords
                DeleteAction::make()
                    ->authorize(fn () => user()?->can(Permission::ACTION_FILE_DELETE, $server))
                    ->hiddenLabel()
-                    ->icon('tabler-trash')->iconSize(IconSize::Large)
+                    ->iconSize(IconSize::Large)
                    ->requiresConfirmation()
                    ->modalHeading(fn (File $file) => trans('filament-actions::delete.single.modal.heading', ['label' => $file->name . ' ' . ($file->is_directory ? 'folder' : 'file')]))
                    ->action(function (File $file) {
--- a/app/Filament/Server/Resources/Schedules/Pages/EditSchedule.php
+++ b/app/Filament/Server/Resources/Schedules/Pages/EditSchedule.php
@ -50,24 +50,20 @@ class EditSchedule extends EditRecord
        return [
            DeleteAction::make()
                ->hiddenLabel()->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-trash')
                ->tooltip(trans('server/schedule.delete'))
                ->after(function ($record) {
                    Activity::event('server:schedule.delete')
                        ->property('name', $record->name)
                        ->log();
                }),
-            ExportScheduleAction::make()
-                ->hiddenLabel()->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-download')
-                ->tooltip(trans('server/schedule.export')),
+            ExportScheduleAction::make(),
            $this->getSaveFormAction()->formId('form')
                ->hiddenLabel()->iconButton()->iconSize(IconSize::ExtraLarge)
                ->icon('tabler-device-floppy')
                ->tooltip(trans('server/schedule.save')),
            $this->getCancelFormAction()->formId('form')
                ->hiddenLabel()->iconButton()->iconSize(IconSize::ExtraLarge)
-                ->icon('tabler-cancel')
+                ->icon('tabler-arrow-left')
                ->tooltip(trans('server/schedule.cancel')),
        ];
    }
--- a/app/Providers/Filament/FilamentServiceProvider.php
+++ b/app/Providers/Filament/FilamentServiceProvider.php
@ -87,6 +87,7 @@ class FilamentServiceProvider extends ServiceProvider

        FilamentIcon::register([
            ActionsIconAlias::DELETE_ACTION => 'tabler-trash',
+            ActionsIconAlias::DETACH_ACTION => 'tabler-trash',
            ActionsIconAlias::EDIT_ACTION => 'tabler-pencil',
            ActionsIconAlias::VIEW_ACTION => 'tabler-eye',
            ActionsIconAlias::REPLICATE_ACTION => 'tabler-copy-plus',
@ -110,7 +111,7 @@ class FilamentServiceProvider extends ServiceProvider
            NotificationsIconAlias::DATABASE_MODAL_EMPTY_STATE => 'tabler-bell-off',
            NotificationsIconAlias::NOTIFICATION_CLOSE_BUTTON => 'tabler-x',
            NotificationsIconAlias::NOTIFICATION_INFO => 'tabler-info-circle',
-            NotificationsIconAlias::NOTIFICATION_SUCCESS => 'tabler-check-circle',
+            NotificationsIconAlias::NOTIFICATION_SUCCESS => 'tabler-circle-check',
            NotificationsIconAlias::NOTIFICATION_WARNING => 'tabler-alert-triangle',
            NotificationsIconAlias::NOTIFICATION_DANGER => 'tabler-alert-circle',