From 189d564f8762eb2fb4814e6fc6ee9a121d65d7bd Mon Sep 17 00:00:00 2001
From: MartinOscar <40749467+RMartinOscar@users.noreply.github.com>
Date: Mon, 3 Jun 2024 06:30:05 +0200
Subject: [PATCH 1/3] Update AllocationsRelationManager.php

---
 .../RelationManagers/AllocationsRelationManager.php           | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php b/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
index f282c4bbc..67a86ff71 100644
--- a/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
+++ b/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
@@ -113,9 +113,11 @@ class AllocationsRelationManager extends RelationManager
 
                                     $start = max((int) $start, 0);
                                     $end = min((int) $end, 2 ** 16 - 1);
-                                    for ($i = $start; $i <= $end; $i++) {
+                                    $range = $start <= $end ? range($start, $end) : range($end, $start);
+                                    foreach ($range as $i) {
                                         $ports->push($i);
                                     }
+
                                 }
 
                                 $uniquePorts = $ports->unique()->values();

From f3171939a43bcb0ae4c758dcf07a98cd0a0b765d Mon Sep 17 00:00:00 2001
From: MartinOscar <40749467+RMartinOscar@users.noreply.github.com>
Date: Mon, 3 Jun 2024 07:11:09 +0200
Subject: [PATCH 2/3] Update AllocationsRelationManager.php

Remove useless range order
---
 .../RelationManagers/AllocationsRelationManager.php             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php b/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
index 67a86ff71..2b11db287 100644
--- a/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
+++ b/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
@@ -113,7 +113,7 @@ class AllocationsRelationManager extends RelationManager
 
                                     $start = max((int) $start, 0);
                                     $end = min((int) $end, 2 ** 16 - 1);
-                                    $range = $start <= $end ? range($start, $end) : range($end, $start);
+                                    $range = range($start, $end);
                                     foreach ($range as $i) {
                                         $ports->push($i);
                                     }

From 5a3b50b31f49faab6ae63e58aa54ab8c194f8fdc Mon Sep 17 00:00:00 2001
From: Lance Pioch <lancepioch@gmail.com>
Date: Mon, 3 Jun 2024 10:34:08 -0400
Subject: [PATCH 3/3] Apply suggestions from code review

---
 .../RelationManagers/AllocationsRelationManager.php           | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php b/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
index 2b11db287..f74cf1fca 100644
--- a/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
+++ b/app/Filament/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
@@ -113,11 +113,9 @@ class AllocationsRelationManager extends RelationManager
 
                                     $start = max((int) $start, 0);
                                     $end = min((int) $end, 2 ** 16 - 1);
-                                    $range = range($start, $end);
-                                    foreach ($range as $i) {
+                                    foreach (range($start, $end) as $i) {
                                         $ports->push($i);
                                     }
-
                                 }
 
                                 $uniquePorts = $ports->unique()->values();