From a7a7c5ba4d3ca862a4a3971b5828616f836d84ed Mon Sep 17 00:00:00 2001
From: MartinOscar <40749467+RMartinOscar@users.noreply.github.com>
Date: Wed, 8 Jan 2025 13:48:36 +0100
Subject: [PATCH] Fix Latest version error (#890)

* Retry if it fails

* Pint
---
 app/Services/Helpers/SoftwareVersionService.php | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/app/Services/Helpers/SoftwareVersionService.php b/app/Services/Helpers/SoftwareVersionService.php
index 5b45b8612..0cfca2cfe 100644
--- a/app/Services/Helpers/SoftwareVersionService.php
+++ b/app/Services/Helpers/SoftwareVersionService.php
@@ -9,7 +9,12 @@ class SoftwareVersionService
 {
     public function latestPanelVersion(): string
     {
-        return cache()->remember('panel:latest_version', now()->addMinutes(config('panel.cdn.cache_time', 60)), function () {
+        $key = 'panel:latest_version';
+        if (cache()->get($key) === 'error') {
+            cache()->forget($key);
+        }
+
+        return cache()->remember($key, now()->addMinutes(config('panel.cdn.cache_time', 60)), function () {
             try {
                 $response = Http::timeout(5)->connectTimeout(1)->get('https://api.github.com/repos/pelican-dev/panel/releases/latest')->throw()->json();
 
@@ -22,7 +27,12 @@ class SoftwareVersionService
 
     public function latestWingsVersion(): string
     {
-        return cache()->remember('wings:latest_version', now()->addMinutes(config('panel.cdn.cache_time', 60)), function () {
+        $key = 'wings:latest_version';
+        if (cache()->get($key) === 'error') {
+            cache()->forget($key);
+        }
+
+        return cache()->remember($key, now()->addMinutes(config('panel.cdn.cache_time', 60)), function () {
             try {
                 $response = Http::timeout(5)->connectTimeout(1)->get('https://api.github.com/repos/pelican-dev/wings/releases/latest')->throw()->json();