From 998ad2ee31d94139f9aefa148b36b18fe48ae5d6 Mon Sep 17 00:00:00 2001 From: Charles Date: Sat, 15 Mar 2025 13:10:25 -0400 Subject: [PATCH] Add hint about overhead when using memory limit (#1069) * Add hint about overhead when using memory limit * Update lang/en/admin/server.php Co-authored-by: Boy132 * escape `'` --------- Co-authored-by: Boy132 --- .../Admin/Resources/ServerResource/Pages/CreateServer.php | 2 ++ .../Admin/Resources/ServerResource/Pages/EditServer.php | 2 ++ lang/en/admin/server.php | 1 + 3 files changed, 5 insertions(+) diff --git a/app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php b/app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php index b529b576a..6508c42f6 100644 --- a/app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php +++ b/app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php @@ -551,6 +551,8 @@ class CreateServer extends CreateRecord ->hidden(fn (Get $get) => $get('unlimited_mem')) ->label(trans('admin/server.memory_limit'))->inlineLabel() ->suffix(config('panel.use_binary_prefix') ? 'MiB' : 'MB') + ->hintIcon('tabler-question-mark') + ->hintIconToolTip(trans('admin/server.memory_helper')) ->default(0) ->required() ->columnSpan(2) diff --git a/app/Filament/Admin/Resources/ServerResource/Pages/EditServer.php b/app/Filament/Admin/Resources/ServerResource/Pages/EditServer.php index c8480f339..11ae0aea6 100644 --- a/app/Filament/Admin/Resources/ServerResource/Pages/EditServer.php +++ b/app/Filament/Admin/Resources/ServerResource/Pages/EditServer.php @@ -248,6 +248,8 @@ class EditServer extends EditRecord ->hidden(fn (Get $get) => $get('unlimited_mem')) ->label(trans('admin/server.memory_limit'))->inlineLabel() ->suffix(config('panel.use_binary_prefix') ? 'MiB' : 'MB') + ->hintIcon('tabler-question-mark') + ->hintIconToolTip(trans('admin/server.memory_helper')) ->required() ->columnSpan(2) ->numeric() diff --git a/lang/en/admin/server.php b/lang/en/admin/server.php index b7039ac84..893979f46 100644 --- a/lang/en/admin/server.php +++ b/lang/en/admin/server.php @@ -36,6 +36,7 @@ return [ 'disabled' => 'Disabled', 'memory' => 'Memory', 'memory_limit' => 'Memory Limit', + 'memory_helper' => 'Wings will add overhead to this value when creating the container to make sure it doesn\'t starve out when using max memory.', 'disk' => 'Disk Space', 'disk_limit' => 'Disk Space Limit', 'advanced_limits' => 'Advanced Limits',