From 69acc48b5e3674b62e27968705014df1688f70be Mon Sep 17 00:00:00 2001 From: Lance Pioch Date: Mon, 17 Jun 2024 10:47:55 -0400 Subject: [PATCH] Use constants --- .../DatabaseHostResource/Pages/CreateDatabaseHost.php | 3 ++- .../DatabaseHostResource/Pages/EditDatabaseHost.php | 3 ++- app/Rules/Port.php | 5 +++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/app/Filament/Resources/DatabaseHostResource/Pages/CreateDatabaseHost.php b/app/Filament/Resources/DatabaseHostResource/Pages/CreateDatabaseHost.php index dd37e5c26..450efd925 100644 --- a/app/Filament/Resources/DatabaseHostResource/Pages/CreateDatabaseHost.php +++ b/app/Filament/Resources/DatabaseHostResource/Pages/CreateDatabaseHost.php @@ -3,6 +3,7 @@ namespace App\Filament\Resources\DatabaseHostResource\Pages; use App\Filament\Resources\DatabaseHostResource; +use App\Models\Objects\Endpoint; use Filament\Resources\Pages\CreateRecord; use Filament\Forms; use Filament\Forms\Components\Section; @@ -44,7 +45,7 @@ class CreateDatabaseHost extends CreateRecord ->numeric() ->default(3306) ->minValue(0) - ->maxValue(65535), + ->maxValue(Endpoint::PORT_CEIL), Forms\Components\TextInput::make('max_databases') ->label('Max databases') ->helpertext('Blank is unlimited.') diff --git a/app/Filament/Resources/DatabaseHostResource/Pages/EditDatabaseHost.php b/app/Filament/Resources/DatabaseHostResource/Pages/EditDatabaseHost.php index 1e46e6055..ba72d59e9 100644 --- a/app/Filament/Resources/DatabaseHostResource/Pages/EditDatabaseHost.php +++ b/app/Filament/Resources/DatabaseHostResource/Pages/EditDatabaseHost.php @@ -4,6 +4,7 @@ namespace App\Filament\Resources\DatabaseHostResource\Pages; use App\Filament\Resources\DatabaseHostResource; use App\Models\DatabaseHost; +use App\Models\Objects\Endpoint; use Filament\Actions; use Filament\Resources\Pages\EditRecord; use Filament\Forms; @@ -39,7 +40,7 @@ class EditDatabaseHost extends EditRecord ->required() ->numeric() ->minValue(0) - ->maxValue(65535), + ->maxValue(Endpoint::PORT_CEIL), Forms\Components\TextInput::make('max_databases') ->label('Max databases') ->helpertext('Blank is unlimited.') diff --git a/app/Rules/Port.php b/app/Rules/Port.php index f2a598c12..910d00379 100644 --- a/app/Rules/Port.php +++ b/app/Rules/Port.php @@ -2,6 +2,7 @@ namespace App\Rules; +use App\Models\Objects\Endpoint; use Closure; use Illuminate\Contracts\Validation\ValidationRule; @@ -23,11 +24,11 @@ class Port implements ValidationRule $fail('The :attribute must be an integer.'); } - if ($value <= 1024) { + if ($value <= Endpoint::PORT_FLOOR) { $fail('The :attribute must be greater than 1024.'); } - if ($value > 65535) { + if ($value > Endpoint::PORT_CEIL) { $fail('The :attribute must be less than 65535.'); } }