banquise/pelican-panel-mirror
14
0
Fork 1
mirror of https://github.com/pelican-dev/panel.git synced 2025-12-08 18:30:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

don't try to bulk update if egg doesn't even have a url (#1887)

Browse Source
This commit is contained in:
mristau 2025-11-13 05:47:38 +01:00 committed by GitHub
parent 108dad09fb
commit 20cb7850ef
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/Filament/Components/Actions/UpdateEggBulkAction.php
View File

@ -49,9 +49,15 @@ class UpdateEggBulkAction extends BulkAction
$success = 0; $success = 0;
$failed = 0; $failed = 0;
$skipped = 0;
/** @var Egg $egg */ /** @var Egg $egg */
foreach ($records as $egg) { foreach ($records as $egg) {
if ($egg->update_url === null) {
$skipped++;
continue;
}
try { try {
$eggImporterService->fromUrl($egg->update_url, $egg); $eggImporterService->fromUrl($egg->update_url, $egg);
@ -67,7 +73,12 @@ class UpdateEggBulkAction extends BulkAction
Notification::make() Notification::make()
->title(trans_choice('admin/egg.updated', 2, ['count' => $success, 'total' => $records->count()])) ->title(trans_choice('admin/egg.updated', 2, ['count' => $success, 'total' => $records->count()]))
->body($failed > 0 ? trans('admin/egg.updated_failed', ['count' => $failed]) : null) ->body(
collect([
$failed > 0 ? trans('admin/egg.updated_failed', ['count' => $failed]) : null,
$skipped > 0 ? trans('admin/egg.updated_skipped', ['count' => $skipped]) : null,
])->filter()->join(' ')
)
->status($failed > 0 ? 'warning' : 'success') ->status($failed > 0 ? 'warning' : 'success')
->persistent() ->persistent()
->send(); ->send();

1
lang/en/admin/egg.php
View File

@ -101,6 +101,7 @@ return [
'update' => 'Update|Update selected', 'update' => 'Update|Update selected',
'updated' => 'Egg updated|:count/:total Eggs updated', 'updated' => 'Egg updated|:count/:total Eggs updated',
'updated_failed' => ':count failed', 'updated_failed' => ':count failed',
'updated_skipped' => ':count skipped',
'update_question' => 'Are you sure you want to update this egg?|Are you sure you want to update the selected eggs?', 'update_question' => 'Are you sure you want to update this egg?|Are you sure you want to update the selected eggs?',
'update_description' => 'If you made any changes to the egg they will be overwritten!|If you made any changes to the eggs they will be overwritten!', 'update_description' => 'If you made any changes to the egg they will be overwritten!|If you made any changes to the eggs they will be overwritten!',
'no_updates' => 'No updates for the selected eggs available', 'no_updates' => 'No updates for the selected eggs available',