Merge branch 'main' into issue/222
# Conflicts: # app/Http/Controllers/Api/Application/Nodes/NodeDeploymentController.php # app/Http/Requests/Api/Application/Nodes/GetDeployableNodesRequest.php # app/Services/Deployment/FindViableNodesService.php # app/Services/Servers/ServerCreationService.php # tests/Integration/Services/Deployment/FindViableNodesServiceTest.php
This commit is contained in:
		
						commit
						51460782cc
					
				| @ -20,6 +20,8 @@ class MakeNodeCommand extends Command | ||||
|                             {--overallocateMemory= : Enter the amount of ram to overallocate (% or -1 to overallocate the maximum).} | ||||
|                             {--maxDisk= : Set the max disk amount.} | ||||
|                             {--overallocateDisk= : Enter the amount of disk to overallocate (% or -1 to overallocate the maximum).} | ||||
|                             {--maxCpu= : Set the max cpu amount.} | ||||
|                             {--overallocateCpu= : Enter the amount of cpu to overallocate (% or -1 to overallocate the maximum).} | ||||
|                             {--uploadSize= : Enter the maximum upload filesize.} | ||||
|                             {--daemonListeningPort= : Enter the daemon listening port.} | ||||
|                             {--daemonSFTPPort= : Enter the daemon SFTP listening port.} | ||||
| @ -58,6 +60,8 @@ class MakeNodeCommand extends Command | ||||
|         $data['memory_overallocate'] = $this->option('overallocateMemory') ?? $this->ask(__('commands.make_node.memory_overallocate')); | ||||
|         $data['disk'] = $this->option('maxDisk') ?? $this->ask(__('commands.make_node.disk')); | ||||
|         $data['disk_overallocate'] = $this->option('overallocateDisk') ?? $this->ask(__('commands.make_node.disk_overallocate')); | ||||
|         $data['cpu'] = $this->option('maxCpu') ?? $this->ask(__('commands.make_node.cpu')); | ||||
|         $data['cpu_overallocate'] = $this->option('overallocateCpu') ?? $this->ask(__('commands.make_node.cpu_overallocate')); | ||||
|         $data['upload_size'] = $this->option('uploadSize') ?? $this->ask(__('commands.make_node.upload_size'), '100'); | ||||
|         $data['daemon_listen'] = $this->option('daemonListeningPort') ?? $this->ask(__('commands.make_node.daemonListen'), '8080'); | ||||
|         $data['daemon_sftp'] = $this->option('daemonSFTPPort') ?? $this->ask(__('commands.make_node.daemonSFTP'), '2022'); | ||||
|  | ||||
| @ -311,6 +311,45 @@ class CreateNode extends CreateRecord | ||||
|                                         ->default(0) | ||||
|                                         ->suffix('%'), | ||||
|                                 ]), | ||||
|                             Forms\Components\Grid::make() | ||||
|                                 ->columns(6) | ||||
|                                 ->columnSpanFull() | ||||
|                                 ->schema([ | ||||
|                                     Forms\Components\ToggleButtons::make('unlimited_cpu') | ||||
|                                         ->label('CPU')->inlineLabel()->inline() | ||||
|                                         ->live() | ||||
|                                         ->afterStateUpdated(fn (Forms\Set $set) => $set('cpu', 0)) | ||||
|                                         ->afterStateUpdated(fn (Forms\Set $set) => $set('cpu_overallocate', 0)) | ||||
|                                         ->formatStateUsing(fn (Forms\Get $get) => $get('cpu') == 0) | ||||
|                                         ->options([ | ||||
|                                             true => 'Unlimited', | ||||
|                                             false => 'Limited', | ||||
|                                         ]) | ||||
|                                         ->colors([ | ||||
|                                             true => 'primary', | ||||
|                                             false => 'warning', | ||||
|                                         ]) | ||||
|                                         ->columnSpan(2), | ||||
|                                     Forms\Components\TextInput::make('cpu') | ||||
|                                         ->dehydratedWhenHidden() | ||||
|                                         ->hidden(fn (Forms\Get $get) => $get('unlimited_cpu')) | ||||
|                                         ->label('CPU Limit')->inlineLabel() | ||||
|                                         ->suffix('%') | ||||
|                                         ->columnSpan(2) | ||||
|                                         ->numeric() | ||||
|                                         ->minValue(0), | ||||
|                                     Forms\Components\TextInput::make('cpu_overallocate') | ||||
|                                         ->dehydratedWhenHidden() | ||||
|                                         ->hidden(fn (Forms\Get $get) => $get('unlimited_cpu')) | ||||
|                                         ->label('Overallocate')->inlineLabel() | ||||
|                                         ->hintIcon('tabler-question-mark') | ||||
|                                         ->hintIconTooltip('The % allowable to go over the set limit.') | ||||
|                                         ->columnSpan(2) | ||||
|                                         ->numeric() | ||||
|                                         ->minValue(-1) | ||||
|                                         ->maxValue(100) | ||||
|                                         ->suffix('%'), | ||||
|                                 ]), | ||||
|                         ]), | ||||
|                 ]), | ||||
|         ]); | ||||
|  | ||||
| @ -318,6 +318,47 @@ class EditNode extends EditRecord | ||||
|                                         ->maxValue(100) | ||||
|                                         ->suffix('%'), | ||||
|                                 ]), | ||||
|                             Forms\Components\Grid::make() | ||||
|                                 ->columns(6) | ||||
|                                 ->columnSpanFull() | ||||
|                                 ->schema([ | ||||
|                                     Forms\Components\ToggleButtons::make('unlimited_cpu') | ||||
|                                         ->label('CPU')->inlineLabel()->inline() | ||||
|                                         ->live() | ||||
|                                         ->afterStateUpdated(fn (Forms\Set $set) => $set('cpu', 0)) | ||||
|                                         ->afterStateUpdated(fn (Forms\Set $set) => $set('cpu_overallocate', 0)) | ||||
|                                         ->formatStateUsing(fn (Forms\Get $get) => $get('cpu') == 0) | ||||
|                                         ->options([ | ||||
|                                             true => 'Unlimited', | ||||
|                                             false => 'Limited', | ||||
|                                         ]) | ||||
|                                         ->colors([ | ||||
|                                             true => 'primary', | ||||
|                                             false => 'warning', | ||||
|                                         ]) | ||||
|                                         ->columnSpan(2), | ||||
|                                     Forms\Components\TextInput::make('cpu') | ||||
|                                         ->dehydratedWhenHidden() | ||||
|                                         ->hidden(fn (Forms\Get $get) => $get('unlimited_cpu')) | ||||
|                                         ->label('CPU Limit')->inlineLabel() | ||||
|                                         ->suffix('%') | ||||
|                                         ->required() | ||||
|                                         ->columnSpan(2) | ||||
|                                         ->numeric() | ||||
|                                         ->minValue(0), | ||||
|                                     Forms\Components\TextInput::make('cpu_overallocate') | ||||
|                                         ->dehydratedWhenHidden() | ||||
|                                         ->hidden(fn (Forms\Get $get) => $get('unlimited_cpu')) | ||||
|                                         ->label('Overallocate')->inlineLabel() | ||||
|                                         ->hintIcon('tabler-question-mark') | ||||
|                                         ->hintIconTooltip('The % allowable to go over the set limit.') | ||||
|                                         ->columnSpan(2) | ||||
|                                         ->required() | ||||
|                                         ->numeric() | ||||
|                                         ->minValue(-1) | ||||
|                                         ->maxValue(100) | ||||
|                                         ->suffix('%'), | ||||
|                                 ]), | ||||
|                         ]), | ||||
|                     Tabs\Tab::make('Configuration File') | ||||
|                         ->icon('tabler-code') | ||||
|  | ||||
| @ -52,6 +52,12 @@ class ListNodes extends ListRecords | ||||
|                     ->suffix(' GiB') | ||||
|                     ->formatStateUsing(fn ($state) => number_format($state / 1024, 2)) | ||||
|                     ->sortable(), | ||||
|                 Tables\Columns\TextColumn::make('cpu') | ||||
|                     ->visibleFrom('sm') | ||||
|                     ->icon('tabler-file') | ||||
|                     ->numeric() | ||||
|                     ->suffix(' %') | ||||
|                     ->sortable(), | ||||
|                 Tables\Columns\IconColumn::make('scheme') | ||||
|                     ->visibleFrom('xl') | ||||
|                     ->label('SSL') | ||||
|  | ||||
| @ -36,7 +36,7 @@ class NodeController extends ApplicationApiController | ||||
|     { | ||||
|         $nodes = QueryBuilder::for(Node::query()) | ||||
|             ->allowedFilters(['uuid', 'name', 'fqdn', 'daemon_token_id']) | ||||
|             ->allowedSorts(['id', 'uuid', 'memory', 'disk']) | ||||
|             ->allowedSorts(['id', 'uuid', 'memory', 'disk', 'cpu']) | ||||
|             ->paginate($request->query('per_page') ?? 50); | ||||
| 
 | ||||
|         return $this->fractal->collection($nodes) | ||||
|  | ||||
| @ -10,8 +10,11 @@ class GetDeployableNodesRequest extends GetNodesRequest | ||||
|             'page' => 'integer', | ||||
|             'memory' => 'required|integer|min:0', | ||||
|             'disk' => 'required|integer|min:0', | ||||
|             'location_ids' => 'array', | ||||
|             'tags' => 'array', | ||||
|             'cpu' => 'sometimes|integer|min:0', | ||||
|             'tags' => 'sometimes|array', | ||||
| 
 | ||||
|             /** @deprecated use tags instead */ | ||||
|             'location_ids' => 'sometimes|array', | ||||
|         ]; | ||||
|     } | ||||
| } | ||||
|  | ||||
| @ -28,6 +28,8 @@ class StoreNodeRequest extends ApplicationApiRequest | ||||
|             'memory_overallocate', | ||||
|             'disk', | ||||
|             'disk_overallocate', | ||||
|             'cpu', | ||||
|             'cpu_overallocate', | ||||
|             'upload_size', | ||||
|             'daemon_listen', | ||||
|             'daemon_sftp', | ||||
|  | ||||
| @ -26,6 +26,8 @@ use Illuminate\Database\Eloquent\Relations\HasManyThrough; | ||||
|  * @property int $memory_overallocate | ||||
|  * @property int $disk | ||||
|  * @property int $disk_overallocate | ||||
|  * @property int $cpu | ||||
|  * @property int $cpu_overallocate | ||||
|  * @property int $upload_size | ||||
|  * @property string $daemon_token_id | ||||
|  * @property string $daemon_token | ||||
| @ -63,6 +65,7 @@ class Node extends Model | ||||
| 
 | ||||
|     public int $sum_memory; | ||||
|     public int $sum_disk; | ||||
|     public int $sum_cpu; | ||||
| 
 | ||||
|     /** | ||||
|      * Fields that are mass assignable. | ||||
| @ -71,7 +74,8 @@ class Node extends Model | ||||
|         'public', 'name', | ||||
|         'fqdn', 'scheme', 'behind_proxy', | ||||
|         'memory', 'memory_overallocate', 'disk', | ||||
|         'disk_overallocate', 'upload_size', 'daemon_base', | ||||
|         'disk_overallocate', 'cpu', 'cpu_overallocate', | ||||
|         'upload_size', 'daemon_base', | ||||
|         'daemon_sftp', 'daemon_listen', | ||||
|         'description', 'maintenance_mode', | ||||
|     ]; | ||||
| @ -87,6 +91,8 @@ class Node extends Model | ||||
|         'memory_overallocate' => 'required|numeric|min:-1', | ||||
|         'disk' => 'required|numeric|min:0', | ||||
|         'disk_overallocate' => 'required|numeric|min:-1', | ||||
|         'cpu' => 'required|numeric|min:0', | ||||
|         'cpu_overallocate' => 'required|numeric|min:-1', | ||||
|         'daemon_base' => 'sometimes|required|regex:/^([\/][\d\w.\-\/]+)$/', | ||||
|         'daemon_sftp' => 'required|numeric|between:1,65535', | ||||
|         'daemon_listen' => 'required|numeric|between:1,65535', | ||||
| @ -104,6 +110,8 @@ class Node extends Model | ||||
|         'memory_overallocate' => 0, | ||||
|         'disk' => 0, | ||||
|         'disk_overallocate' => 0, | ||||
|         'cpu' => 0, | ||||
|         'cpu_overallocate' => 0, | ||||
|         'daemon_base' => '/var/lib/pelican/volumes', | ||||
|         'daemon_sftp' => 2022, | ||||
|         'daemon_listen' => 8080, | ||||
| @ -116,6 +124,7 @@ class Node extends Model | ||||
|         return [ | ||||
|             'memory' => 'integer', | ||||
|             'disk' => 'integer', | ||||
|             'cpu' => 'integer', | ||||
|             'daemon_listen' => 'integer', | ||||
|             'daemon_sftp' => 'integer', | ||||
|             'behind_proxy' => 'boolean', | ||||
| @ -239,12 +248,13 @@ class Node extends Model | ||||
|     /** | ||||
|      * Returns a boolean if the node is viable for an additional server to be placed on it. | ||||
|      */ | ||||
|     public function isViable(int $memory, int $disk): bool | ||||
|     public function isViable(int $memory, int $disk, int $cpu): bool | ||||
|     { | ||||
|         $memoryLimit = $this->memory * (1 + ($this->memory_overallocate / 100)); | ||||
|         $diskLimit = $this->disk * (1 + ($this->disk_overallocate / 100)); | ||||
|         $cpuLimit = $this->cpu * (1 + ($this->cpu_overallocate / 100)); | ||||
| 
 | ||||
|         return ($this->sum_memory + $memory) <= $memoryLimit && ($this->sum_disk + $disk) <= $diskLimit; | ||||
|         return ($this->sum_memory + $memory) <= $memoryLimit && ($this->sum_disk + $disk) <= $diskLimit && ($this->sum_cpu + $cpu) <= $cpuLimit; | ||||
|     } | ||||
| 
 | ||||
|     public static function getForServerCreation() | ||||
|  | ||||
| @ -12,8 +12,8 @@ class FindViableNodesService | ||||
|      * be passed to the AllocationSelectionService to return a single allocation. | ||||
|      * | ||||
|      * This functionality is used for automatic deployments of servers and will | ||||
|      * attempt to find all nodes in the defined locations that meet the disk and | ||||
|      * memory availability requirements. Any nodes not meeting those requirements | ||||
|      * attempt to find all nodes in the defined locations that meet the memory, disk | ||||
|      * and cpu availability requirements. Any nodes not meeting those requirements | ||||
|      * are tossed out, as are any nodes marked as non-public, meaning automatic | ||||
|      * deployments should not be done against them. | ||||
|      */ | ||||
|  | ||||
| @ -57,13 +57,13 @@ class TransferServerService | ||||
| 
 | ||||
|         // Check if the node is viable for the transfer.
 | ||||
|         $node = Node::query() | ||||
|             ->select(['nodes.id', 'nodes.fqdn', 'nodes.scheme', 'nodes.daemon_token', 'nodes.daemon_listen', 'nodes.memory', 'nodes.disk', 'nodes.memory_overallocate', 'nodes.disk_overallocate']) | ||||
|             ->selectRaw('IFNULL(SUM(servers.memory), 0) as sum_memory, IFNULL(SUM(servers.disk), 0) as sum_disk') | ||||
|             ->select(['nodes.id', 'nodes.fqdn', 'nodes.scheme', 'nodes.daemon_token', 'nodes.daemon_listen', 'nodes.memory', 'nodes.disk', 'nodes.cpu', 'nodes.memory_overallocate', 'nodes.disk_overallocate', 'nodes.cpu_overallocate']) | ||||
|             ->selectRaw('IFNULL(SUM(servers.memory), 0) as sum_memory, IFNULL(SUM(servers.disk), 0) as sum_disk, IFNULL(SUM(servers.cpu), 0) as sum_cpu') | ||||
|             ->leftJoin('servers', 'servers.node_id', '=', 'nodes.id') | ||||
|             ->where('nodes.id', $node_id) | ||||
|             ->first(); | ||||
| 
 | ||||
|         if (!$node->isViable($server->memory, $server->disk)) { | ||||
|         if (!$node->isViable($server->memory, $server->disk, $server->cpu)) { | ||||
|             return false; | ||||
|         } | ||||
| 
 | ||||
|  | ||||
| @ -23,27 +23,23 @@ class NodeTransformer extends BaseTransformer | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Return a node transformed into a format that can be consumed by the | ||||
|      * external administrative API. | ||||
|      * Return a node transformed into a format that can be consumed by the external administrative API. | ||||
|      */ | ||||
|     public function transform(Node $node): array | ||||
|     { | ||||
|         $response = collect($node->toArray())->mapWithKeys(function ($value, $key) { | ||||
|             // I messed up early in 2016 when I named this column as poorly
 | ||||
|             // as I did. This is the tragic result of my mistakes.
 | ||||
|             $key = ($key === 'daemon_sftp') ? 'daemon_sftp' : $key; | ||||
| 
 | ||||
|             return [snake_case($key) => $value]; | ||||
|         })->toArray(); | ||||
|         $response = collect($node->toArray()) | ||||
|             ->mapWithKeys(fn ($value, $key) => [snake_case($key) => $value]) | ||||
|             ->toArray(); | ||||
| 
 | ||||
|         $response[$node->getUpdatedAtColumn()] = $this->formatTimestamp($node->updated_at); | ||||
|         $response[$node->getCreatedAtColumn()] = $this->formatTimestamp($node->created_at); | ||||
| 
 | ||||
|         $resources = $node->servers()->select(['memory', 'disk'])->get(); | ||||
|         $resources = $node->servers()->select(['memory', 'disk', 'cpu'])->get(); | ||||
| 
 | ||||
|         $response['allocated_resources'] = [ | ||||
|             'memory' => $resources->sum('memory'), | ||||
|             'disk' => $resources->sum('disk'), | ||||
|             'cpu' => $resources->sum('cpu'), | ||||
|         ]; | ||||
| 
 | ||||
|         return $response; | ||||
|  | ||||
| @ -10,7 +10,7 @@ return [ | ||||
|         'sqlite' => [ | ||||
|             'driver' => 'sqlite', | ||||
|             'url' => env('DB_URL'), | ||||
|             'database' => env('DB_DATABASE', database_path('database.sqlite')), | ||||
|             'database' => database_path(env('DB_DATABASE', 'database.sqlite')), | ||||
|             'prefix' => '', | ||||
|             'foreign_key_constraints' => env('DB_FOREIGN_KEYS', true), | ||||
|         ], | ||||
|  | ||||
| @ -33,6 +33,8 @@ class NodeFactory extends Factory | ||||
|             'memory_overallocate' => 0, | ||||
|             'disk' => 10240, | ||||
|             'disk_overallocate' => 0, | ||||
|             'cpu' => 100, | ||||
|             'cpu_overallocate' => 0, | ||||
|             'upload_size' => 100, | ||||
|             'daemon_token_id' => Str::random(Node::DAEMON_TOKEN_ID_LENGTH), | ||||
|             'daemon_token' => Crypt::encrypt(Str::random(Node::DAEMON_TOKEN_LENGTH)), | ||||
|  | ||||
| @ -0,0 +1,30 @@ | ||||
| <?php | ||||
| 
 | ||||
| use Illuminate\Database\Migrations\Migration; | ||||
| use Illuminate\Database\Schema\Blueprint; | ||||
| use Illuminate\Support\Facades\Schema; | ||||
| 
 | ||||
| return new class extends Migration | ||||
| { | ||||
|     /** | ||||
|      * Run the migrations. | ||||
|      */ | ||||
|     public function up(): void | ||||
|     { | ||||
|         Schema::table('nodes', function (Blueprint $table) { | ||||
|             $table->unsignedInteger('cpu')->default(0)->after('disk_overallocate'); | ||||
|             $table->integer('cpu_overallocate')->default(0)->after('cpu'); | ||||
|         }); | ||||
|     } | ||||
| 
 | ||||
|     /** | ||||
|      * Reverse the migrations. | ||||
|      */ | ||||
|     public function down(): void | ||||
|     { | ||||
|         Schema::table('nodes', function (Blueprint $table) { | ||||
|             $table->dropColumn('cpu'); | ||||
|             $table->dropColumn('cpu_overallocate'); | ||||
|         }); | ||||
|     } | ||||
| }; | ||||
| @ -359,6 +359,8 @@ CREATE TABLE `nodes` ( | ||||
|                          `memory_overallocate` int NOT NULL DEFAULT '0', | ||||
|                          `disk` int unsigned NOT NULL, | ||||
|                          `disk_overallocate` int NOT NULL DEFAULT '0', | ||||
|                          `cpu` int unsigned NOT NULL DEFAULT '0', | ||||
|                          `cpu_overallocate` int NOT NULL DEFAULT '0', | ||||
|                          `upload_size` int unsigned NOT NULL DEFAULT '100', | ||||
|                          `daemon_token_id` char(16) COLLATE utf8mb4_unicode_ci NOT NULL, | ||||
|                          `daemon_token` text CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL, | ||||
| @ -845,3 +847,4 @@ INSERT INTO `migrations` (`id`, `migration`, `batch`) VALUES (198,'2024_03_14_05 | ||||
| INSERT INTO `migrations` (`id`, `migration`, `batch`) VALUES (201,'2024_04_20_214441_add_egg_var_sort',3); | ||||
| INSERT INTO `migrations` (`id`, `migration`, `batch`) VALUES (203,'2024_04_14_002250_update_column_names',4); | ||||
| INSERT INTO `migrations` (`id`, `migration`, `batch`) VALUES (204,'2024_05_08_094823_rename_oom_disabled_column_to_oom_killer',1); | ||||
| INSERT INTO `migrations` (`id`, `migration`, `batch`) VALUES (205,'2024_05_16_091207_add_cpu_columns_to_nodes_table',1); | ||||
|  | ||||
| @ -31,7 +31,9 @@ return [ | ||||
|         'memory' => 'Enter the maximum amount of memory', | ||||
|         'memory_overallocate' => 'Enter the amount of memory to over allocate by, -1 will disable checking and 0 will prevent creating new servers', | ||||
|         'disk' => 'Enter the maximum amount of disk space', | ||||
|         'disk_overallocate' => 'Enter the amount of memory to over allocate by, -1 will disable checking and 0 will prevent creating new server', | ||||
|         'disk_overallocate' => 'Enter the amount of disk to over allocate by, -1 will disable checking and 0 will prevent creating new server', | ||||
|         'cpu' => 'Enter the maximum amount of cpu', | ||||
|         'cpu_overallocate' => 'Enter the amount of cpu to over allocate by, -1 will disable checking and 0 will prevent creating new server', | ||||
|         'upload_size' => "'Enter the maximum filesize upload", | ||||
|         'daemonListen' => 'Enter the daemon listening port', | ||||
|         'daemonSFTP' => 'Enter the daemon SFTP listening port', | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 Lance Pioch
						Lance Pioch