Tests: Make PHPstan run in 8.2, 8.3 & 8.4 (#1072)

* Add PHP [8.2,8.3,8.4] matrices to `phpstan`

* Use a pointer with `unset($this)` to make PHP 8.4 happy
This commit is contained in:
MartinOscar 2025-03-09 01:58:50 +01:00 committed by GitHub
parent 0179ade557
commit 3a24edfe1d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 23 additions and 4 deletions

View File

@ -32,14 +32,31 @@ jobs:
phpstan:
name: PHPStan
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
php: [8.2, 8.3, 8.4]
steps:
- name: Code Checkout
uses: actions/checkout@v4
- name: Get cache directory
id: composer-cache
run: |
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
- name: Cache
uses: actions/cache@v4
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-${{ matrix.php }}-
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: "8.3"
php-version: ${{ matrix.php }}
extensions: bcmath, curl, gd, mbstring, mysql, openssl, pdo, tokenizer, xml, zip
tools: composer:v2
coverage: none

View File

@ -156,8 +156,9 @@ class BackupManager
*/
public function forget(array|string $adapter): self
{
$adapters = &$this->adapters;
foreach ((array) $adapter as $adapterName) {
unset($this->adapters[$adapterName]);
unset($adapters[$adapterName]);
}
return $this;

View File

@ -26,7 +26,8 @@ class AlertBannerContainer extends Component
public function remove(string $id): void
{
unset($this->alertBanners[$id]);
$alertBanners = &$this->alertBanners;
unset($alertBanners[$id]);
}
public function render(): View