Tests: Make PHPstan
run in 8.2, 8.3 & 8.4 (#1072)
* Add PHP [8.2,8.3,8.4] matrices to `phpstan` * Use a pointer with `unset($this)` to make PHP 8.4 happy
This commit is contained in:
parent
0179ade557
commit
3a24edfe1d
19
.github/workflows/lint.yaml
vendored
19
.github/workflows/lint.yaml
vendored
@ -32,14 +32,31 @@ jobs:
|
|||||||
phpstan:
|
phpstan:
|
||||||
name: PHPStan
|
name: PHPStan
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
strategy:
|
||||||
|
fail-fast: false
|
||||||
|
matrix:
|
||||||
|
php: [8.2, 8.3, 8.4]
|
||||||
steps:
|
steps:
|
||||||
- name: Code Checkout
|
- name: Code Checkout
|
||||||
uses: actions/checkout@v4
|
uses: actions/checkout@v4
|
||||||
|
|
||||||
|
- name: Get cache directory
|
||||||
|
id: composer-cache
|
||||||
|
run: |
|
||||||
|
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
|
||||||
|
|
||||||
|
- name: Cache
|
||||||
|
uses: actions/cache@v4
|
||||||
|
with:
|
||||||
|
path: ${{ steps.composer-cache.outputs.dir }}
|
||||||
|
key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ hashFiles('**/composer.lock') }}
|
||||||
|
restore-keys: |
|
||||||
|
${{ runner.os }}-composer-${{ matrix.php }}-
|
||||||
|
|
||||||
- name: Setup PHP
|
- name: Setup PHP
|
||||||
uses: shivammathur/setup-php@v2
|
uses: shivammathur/setup-php@v2
|
||||||
with:
|
with:
|
||||||
php-version: "8.3"
|
php-version: ${{ matrix.php }}
|
||||||
extensions: bcmath, curl, gd, mbstring, mysql, openssl, pdo, tokenizer, xml, zip
|
extensions: bcmath, curl, gd, mbstring, mysql, openssl, pdo, tokenizer, xml, zip
|
||||||
tools: composer:v2
|
tools: composer:v2
|
||||||
coverage: none
|
coverage: none
|
||||||
|
@ -156,8 +156,9 @@ class BackupManager
|
|||||||
*/
|
*/
|
||||||
public function forget(array|string $adapter): self
|
public function forget(array|string $adapter): self
|
||||||
{
|
{
|
||||||
|
$adapters = &$this->adapters;
|
||||||
foreach ((array) $adapter as $adapterName) {
|
foreach ((array) $adapter as $adapterName) {
|
||||||
unset($this->adapters[$adapterName]);
|
unset($adapters[$adapterName]);
|
||||||
}
|
}
|
||||||
|
|
||||||
return $this;
|
return $this;
|
||||||
|
@ -26,7 +26,8 @@ class AlertBannerContainer extends Component
|
|||||||
|
|
||||||
public function remove(string $id): void
|
public function remove(string $id): void
|
||||||
{
|
{
|
||||||
unset($this->alertBanners[$id]);
|
$alertBanners = &$this->alertBanners;
|
||||||
|
unset($alertBanners[$id]);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function render(): View
|
public function render(): View
|
||||||
|
Loading…
x
Reference in New Issue
Block a user