feat/bulkUserCreate #21

Merged
malopieds merged 8 commits from feat/bulkUserCreate into master 2026-03-20 20:15:58 +01:00
No description provided.
feat: link users & ji
Some checks failed
Pull Request / build pull request (pull_request) Failing after 6m33s
684de10df5
malopieds requested changes 2026-03-14 22:36:30 +01:00
Dismissed
malopieds left a comment
Owner
  • Creer une fonction bulkcreatecontainer(List)
  • iter sur la liste => pour chaque user tu cree un container et tu lui donnes son SecurityUser
  • persist la list de ContainerModel tout d'un coup
- [ ] Creer une fonction bulkcreatecontainer(List<SecurityUser>) - [ ] iter sur la liste => pour chaque user tu cree un container et tu lui donnes son SecurityUser - [ ] persist la list de ContainerModel tout d'un coup
@ -22,6 +22,7 @@ dependencies {
)
api(project(":common"))
api(project(":database"))
api(project(":users"))
Owner

remove user module

remove user module
@ -57,6 +62,13 @@ class ContainerService(
if (jiRequest.start) startContainer(container.id)
val c: ContainerModel = ContainerModel().apply {
Owner

rename ta var c encule

rename ta var c encule
@ -59,1 +64,4 @@
val c: ContainerModel = ContainerModel().apply {
containerId = container.id
username = userService.getUser(jiRequest.username)
Owner

remove userService

remove userService
@ -60,0 +67,4 @@
username = userService.getUser(jiRequest.username)
}
containerRepository.persist(c)
Owner

Tout le code link username avec container ca degage dans bulkcreatecontainer =>pas de link si 1 seul create container, au future delete createjicontainer en soit il sert a rien en lui tout seul

Tout le code link username avec container ca degage dans bulkcreatecontainer =>pas de link si 1 seul create container, au future delete createjicontainer en soit il sert a rien en lui tout seul
@ -20,0 +24,4 @@
class UserService(private val userRepository: UserRepository,
private val jdmiService: JdmiService,
private val containerService: ContainerService,
private val containerRepository: ContainerRepository
Owner

Utilise un service dans les autres services pas un repo

Utilise un service dans les autres services pas un repo
@ -80,0 +95,4 @@
containerService.createJIContainer(DockerJIRequest(
imageName = "git.la-banquise.fr/banquise/ji-container:latest",
containerName = "jdmi-${it.login}-jdmiId",
port = containerRepository.find("ORDER BY port DESC").firstResult()?.port?.plus(1),
Owner

Dans le repo directement + un max

Dans le repo directement + un max
fix: building + bulk containers creation
All checks were successful
Pull Request / build pull request (pull_request) Successful in 9m45s
50404391f3
malopieds force-pushed feat/bulkUserCreate from 50404391f3
All checks were successful
Pull Request / build pull request (pull_request) Successful in 9m45s
to 559eeac772
All checks were successful
Pull Request / build pull request (pull_request) Successful in 8m2s
2026-03-20 17:53:40 +01:00
Compare
feat: link users to containers and ji
All checks were successful
Pull Request / build pull request (pull_request) Successful in 9m37s
b567a5888f
fix: few fixes
Some checks failed
Pull Request / build pull request (pull_request) Failing after 2m55s
115c564616
fix: add BulkContainersRequestedEvent data class
All checks were successful
Pull Request / build pull request (pull_request) Successful in 9m12s
757c2c5029
thomas.le-magoariec left a comment
Author
Member

where resource to get all containers associated with a jdmi ?
genre jdmi Id into listOf avec leur info et creds*

where resource to get all containers associated with a jdmi ? genre jdmi Id into listOf<Docker mes couilles> avec leur info et creds*
@ -0,0 +17,4 @@
var containerId: String? = null
var port: Int? = null
Author
Member

why nullable ?

why nullable ?
Owner

On peut imaginer dans un futur un truc sans port, mais en soit oui le nullable est pas obligatoire ici, flemme de faire tourner une PR pour ca tbh mdr

On peut imaginer dans un futur un truc sans port, mais en soit oui le nullable est pas obligatoire ici, flemme de faire tourner une PR pour ca tbh mdr
Owner

@thomas.le-magoariec wrote in #21 (comment):

where resource to get all containers associated with a jdmi ? genre jdmi Id into listOf avec leur info et creds*

Prochaine PR

@thomas.le-magoariec wrote in https://git.la-banquise.fr/banquise/intra-back/pulls/21#issuecomment-327: > where resource to get all containers associated with a jdmi ? genre jdmi Id into listOf avec leur info et creds* Prochaine PR
malopieds approved these changes 2026-03-20 20:10:09 +01:00
malopieds merged commit c21d55ede8 into master 2026-03-20 20:15:58 +01:00
malopieds deleted branch feat/bulkUserCreate 2026-03-20 20:15:58 +01:00
malopieds referenced this pull request from a commit 2026-03-20 20:15:59 +01:00
thomas.le-magoariec referenced this pull request from a commit 2026-03-21 16:30:01 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
banquise/intra-back!21
No description provided.